Posts by -Dis

    I don't think so. All VDR has is a "resume" file which is placed next to the other recording files: http://www.vdr-wiki.de/wiki/index.php/Resume

    It stores a frame number and only one per recording.

    According to that wiki page (Google translated):

    Quote

    If a value greater than 0 is entered as the "Playback ID" in the OSD setup under "Playback", then resume files created after this will have this playback ID in their name (e.g. resume.1). For example, you can run vdr on several PCs and still use the same recording directory over the network.

    But yep this is only available in VDR and not possible to use with VNSI because I can't deliver id to cResumeFile

    vdr/recording.c at 8b14723e9ef4f408cfb357f6c27235cf491efd12 · vdr-projects/vdr
    Mirror of the official VDR GIT repository. Contribute to vdr-projects/vdr development by creating an account on GitHub.
    github.com


    Feature is also useful if you want to see if recording is watched or not from Live plugin :)

    Yep it will get urls for images from Live plugin if Live service is found.


    If -u URL or --url=URL is not in Live start parameters then it will return same file path as given to Live service (local file path).


    Live plugin is not required when VDR and Kodi are in same device. I don't know is there some way to detect if server and client are in same device and skip Live plugin in that case. Is there even any benefits doing that? :D

    Good idea to make it possible to disable (and disable by default) the "resume point" feature. Very useful if one person has several clients but would be a bad idea in a family with one central server where everyone watches recordings on his own client.


    If I remember correctly VDR supports resume points per client. So if I implement client id's to Kodi client then it would be possible save resume points to VDR server without using same resume points for every client.


    Edit. quickly looking VDR source code it seems to be possible only if VDR itself is client :(


    And I still think that -Dis should at least co-maintain vdr-plugin-vnsiserver as probably he is the person with the deepest insight into the plugin currently.

    I can help to review PR's but I don't have much knowledge other parts of vnsiserver than those I made changes (EPG and recording listings).

    Here's instructions how to test these new features.


    Get latest vdr-plugin-live

    Code
    git clone https://github.com/MarkusEh/vdr-plugin-live
    cd vdr-plugin-live
    make
    make install


    Install vdr-plugin-tvscraper example from this PPA https://launchpad.net/~seahawk…+archive/ubuntu/vdr-2.6.3

    Set channels which you want to scrape from plugin settings on VDR.


    vdr-plugin-vnsiserver

    Code
    git clone https://github.com/Dis90/vdr-plugin-vnsiserver -b tvscraper_backendresume
    cd vdr-plugin-vnsiserver
    make
    make install


    Kodi add-on if your Kodi is installed on Windows/Mac/Android/iOS you can get from here: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.vdr.vnsi/detail/PR-180/6/artifacts


    Build instructions:

    Code
    mkdir kodi_vnsi
    cd kodi_vnsi
    git clone https://github.com/xbmc/xbmc -b Nexus
    git clone https://github.com/Dis90/pvr.vdr.vnsi -b tvscraper_backendresume_nexus
    cd pvr.vdr.vnsi && mkdir build && cd build
    cmake -DADDONS_TO_BUILD=pvr.vdr.vnsi -DADDON_SRC_PREFIX=../.. -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=../../xbmc/addons -DPACKAGE_ZIP=1 ../../xbmc/cmake/addons
    make

    Copy build add-on to Kodi

    Code
    cd ../../xbmc/addons/
    sudo cp -r pvr.vdr.vnsi/ /usr/lib/x86_64-linux-gnu/kodi/addons/


    Restart Kodi


    If you want to Kodi to use VDR resume point on recordings you need to enable backend resume from Kodi add-on settings.

    > Is new interface ready to use?

    No :( .

    Okay, no rush :)

    For your off topic questions, please check the Tvscraper plugin settings. You can select a language for each channel.

    Thanks. Found settings but I can't change system language or additional language to Finnish :( How I can add Finnish to available options?

    Edit. I added:

    Code
    {11, "fin", "fi-FI", "suomi"}


    to config.h and rebuild plugin and changed plugin default/system language to 11 and additional to 6. Lets see if that fixes the issue :)

    I'm getting this error to syslog and vdr restarts after that.


    I somehow hoped to get a bit more feedback.

    Yeah I hoped that too :( Phunkyfish just recommended me to ask testers from Kodi forums (https://github.com/kodi-pvr/pvr.vdr.vnsi/pull/180). But do we need more testers for these features?


    As far as I remember testing tvscraper is just installing the plugin?

    What I can remember after installing you need to set what channels you want to scrap from plugin settings.


    If someday scraper2vdr starts to support new interface we can easily add support for it without modifications needed to Kodi VNSI plugin.

    Still, for KODI plugins, using internet URLs for images is best practice as KODI itself uses internet URLs for images.

    Thanks for confirming how Kodi plugins do this. With reference to this matter I'm not going to change anything but maybe also add support for scraper2vdr if there's demand. But with scraper2vdr artwork support would be limited to VDR and Kodi in same machine.

    M-Reimer What you think if I change code "little bit" and add support for scraper2vdr by using old interface for it.


    Something like this:

    Code
    static cPlugin *pTVScraper = cPluginManager::GetPlugin("tvscraper");
    static cPlugin *pScraper = cPluginManager::GetPlugin("scraper2vdr");
          if (pTVScraper)
          {
            ...
          }
          else if (pScraper)
          {
            ...
          }


    New interface also supports local image paths if we are going that way.