Posts by -Dis

    I'm getting this error to syslog and vdr restarts after that.


    I somehow hoped to get a bit more feedback.

    Yeah I hoped that too :( Phunkyfish just recommended me to ask testers from Kodi forums (https://github.com/kodi-pvr/pvr.vdr.vnsi/pull/180). But do we need more testers for these features?


    As far as I remember testing tvscraper is just installing the plugin?

    What I can remember after installing you need to set what channels you want to scrap from plugin settings.


    If someday scraper2vdr starts to support new interface we can easily add support for it without modifications needed to Kodi VNSI plugin.

    Still, for KODI plugins, using internet URLs for images is best practice as KODI itself uses internet URLs for images.

    Thanks for confirming how Kodi plugins do this. With reference to this matter I'm not going to change anything but maybe also add support for scraper2vdr if there's demand. But with scraper2vdr artwork support would be limited to VDR and Kodi in same machine.

    M-Reimer What you think if I change code "little bit" and add support for scraper2vdr by using old interface for it.


    Something like this:

    Code
    1. static cPlugin *pTVScraper = cPluginManager::GetPlugin("tvscraper");
    2. static cPlugin *pScraper = cPluginManager::GetPlugin("scraper2vdr");
    3. if (pTVScraper)
    4. {
    5.         ...
    6.       }
    7. else if (pScraper)
    8. {
    9.         ...
    10.       }


    New interface also supports local image paths if we are going that way.

    This is also the first idea that came to my mind (without any knowledge if this is possible at all). Actually the VNSI protocol was meant to be a universal protocol to do all the communication needed to get Kodi connected with VDR. And as it does work for transporting whole video streams, I guess transmitting of small images should be possible.

    I too doesn't have knowledge but I remember reading somewhere from Kodi forums (VNSI section) that this isn't possible. And even if it is possible I don't have skills to do it :(


    And yes, it is attractive to just make Kodi do the image download. If others PVR addons would do the same, then I would say: Just keep it that way. But noone of us knows what limitations this would mean in future (Referer check, Cookie, ...) and I'm a big fan of "do it once and do it right".

    I understand your point.


    Currently I don't have any ideas how to solve this issue.

    Because after thinking a bit more, I am more and more unsure if it is a good idea to send "internet accessible" links at all.


    For my knowledge Kodi caches all images. So same image is not downloaded twice and images are downloaded only when needed example browsing epg events.


    Data providers are coming and going. For example epgdata is "going" soon.

    This is only issue when browsing recordings and you can always re-scrape them.

    If other PVR backends also don't prepare for this case (if they also send deep links to Kodi) then this may be not a that big priority but if others decided to transfer images using their own protocol, then maybe this is not the worst idea.


    At least Nextpvr provides own url's for images (https://github.com/kodi-pvr/pv…9/src/Recordings.cpp#L377)


    In best case Tvscraper would act as server for images so image url then would be something like https://server_ip/... instead of local path (/var/cache...)


    I doesn't have answer what is best method to use. If only local paths are provided to Kodi then those would not work when VDR and Kodi are in different machines. How this situation is handled in scraper2vdr?

    Samba share is one option to go. There's also some informations what are not available on older Tvscraper interface (director, writer) but in my opinion that is not critical info.


    I'm open for all ideas.


    If someone has solution for how to provide paths for images way that them work in all situations (VDR and Kodi in different machines). Then I can update vnsi to use methods compatible with scraper2vdr.


    I've been also thinking of dropping tvscraper support and only add resumepoints support to vnsi because there's this module available on Kodi https://github.com/b-jesch/script.module.pvr.artwork but this needs skin which has support for it.


    I don't know why Github made that I and I don't know how to fix it.


    And about instancing the plugin link to VDR, you did here: https://github.com/vdr-project…87ed4ae610def78340d2R2735

    If you borrow the instancing from the skindesigner plugin https://gitlab.com/kamel5/skin…/extensions/helpers.c#L10 , then your change also works with "scraper2vdr" which, I think, is used more often. This could also mean more audience for testing your change.


    That is what I initially did but after current maintainer of tvscraper suggested making new interface for this, it is no longer backwards compatible. This decision is mainly done to help in situations when VDR is in different machine than Kodi. New interface provides http url's for images instead of local filepaths.

    See: https://forum.kodi.tv/showthre…35&pid=3092181#pid3092181


    Supporting both scraper2vdr and tvscraper is still possible but makes code ugly and then we have to somehow deal situations when VDR and Kodi are in different machines.

    I've made version of VDR vnsiserver and Kodi VNSI client which supports movie and tv series artwork and backend resumepoints.


    As M-Reimer wrote here https://github.com/vdr-project…1#issuecomment-1114184774 I need testers for this so we can be sure that everything works.


    In order to use these new features you need modified vnsiserver and Kodi client. You need to build both yourself. Also latest vdr-plugin-tvscraper is needed (available on yavdr ppa) https://github.com/MarkusEh/vdr-plugin-tvscraper

    For using backend resume enable it on Kodi vnsi client settings.


    Links:

    vnsiserver: https://github.com/Dis90/vdr-p…e/tvscraper_backendresume


    pvr.vdr.vnsi:

    Kodi Matrix: https://github.com/Dis90/pvr.v…aper_backendresume_matrix

    Kodi Nexus: https://github.com/Dis90/pvr.v…raper_backendresume_nexus

    Windows/OSX/Android builds can be found here: https://jenkins.kodi.tv/blue/o…detail/PR-180/2/artifacts


    Pull requests made to https://github.com/vdr-projects/vdr-plugin-vnsiserver/pull/1 and https://github.com/kodi-pvr/pvr.vdr.vnsi/pull/180

    Good that there's only copy in recording folder :)


    Yep TVDB is better but I've heard rumors that old API stops working in some time and that it starts to cost something. Any way good to have options.


    Another nice thing to have would be some way to start EPG and recording scraping from command line (SVDRP?).

    First thanks for update. I have couple questions about new version.


    1. I noticed that tvscraper now keeps images for recordings in recording folder. What location example ScraperGetPoster returns for recording images? Is it still /var/cache/vdr/plugins/tvscraper/...? I'm asking this because I've been working on tvscraper support for VNSI Server and Client and from client side it is possible to specify where images are located if those aren't in same machine with Kodi. If images aren't in one folder example default /var/cache/vdr/plugins/tvscraper/ it would broke that feature.


    2. Is is possible to disable TVDB scraper and just use MovieDB for movies and tvshows?


    Links to my versions of VNSI Server and Client if anyone wants to try it. P.S. If someone wants to take this project from me, I'm OK with that :)

    https://github.com/Dis90/vdr-p…e/tvscraper_backendresume

    https://github.com/Dis90/pvr.v…aper_backendresume_matrix

    https://github.com/Dis90/pvr.v…raper_backendresume_nexus

    I can't get this to build.

    Code
    1. telkka@telkka:~/vdr-plugin-tvscraper$ make
    2. g++ -g -O3 -Wall -Werror=overloaded-virtual -Wno-parentheses -fPIC -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -std=c++17 -c -DPLUGIN_NAME_I18N='"tvscraper"' -I/usr/include/libxml2 -o tvscraper.o tvscraper.c
    3. In file included from tvscraper.c:13:
    4. tools/jsonHelpers.c:1:10: fatal error: jansson.h: Tiedostoa tai hakemistoa ei ole
    5. 1 | #include <jansson.h>
    6. | ^~~~~~~~~~~
    7. compilation terminated.
    8. make: *** [Makefile:73: tvscraper.o] Virhe 1

    These messages are probably normal?