[ANNOUNCE] vaapivideo 1.8.2

Quote from pluto

Kannst du mir einen Tipp geben, wie ich diese aktiviere? Deinterlace, Denoise, Sharpen und Scaling stehen alle auf auto.

Deinterlace: bwdif

Release 1.7.4

mediaplayer resume bookmark, demux thread-safety, audio-only trick play

• Mediaplayer: persist a single resume bookmark to setup.conf (vaapivideo.BookmarkUri / BookmarkPositionMs). Every stop saves the current position; relaunching the same file resumes exactly there. Playlists and network streams bookmark only the origin URI; the file browser reopens on the bookmark with the cursor on the file
• Mediaplayer: save the bookmark from every teardown path (Stop, EOF, channel switch, shutdown, SVDRP replace) -- inline on the main thread, deferred to Housekeeping() for the off-thread SVDRP case, with dirty-flag retry on a failed setup.conf write
• Mediaplayer: make GetIndex/FramesPerSecond/MakeBookmark lock-free via cached duration/fps atomics so the VDR main loop never blocks behind a stalled demux read; stop holding sourceMutex across avformat_open_input; slim the player State enum to {Running, Eof, Stopped}, dropping dead cross-thread writes
• Radio (audio-only) trick play: HasIBPTrickSpeed() now tracks whether video is playing, so fast-forward on a video-less recording no longer runs to EOF in a second; trick steps are paced on the decoder deadline and the slow-forward hold is derived from the PTS step
• Radio replay: GetSTC() falls back to the trick-step PTS then the audio clock when no video frame stamped a position, so audio-only replays report a valid STC in trick modes and resume at their real position instead of a stale one
• Trick pacing: close the lock-free memory-ordering gaps on the radio path (acquire-load trickSpeed before the pacing flags; reset trickAudioPts before the release-store) and reset trick position state on every exit path
• Docs: document the new setup.conf bookmark keys (README) and the mediaplayer feed-pacing constants (AVSYNC.md)

Release 1.8.0

runtime display-mode switching

• New: the display can now follow the content. "Match refresh rate" re-programs the output to an exact multiple of the source frame rate (24p plays at 24/48 Hz, 59.94 is told apart from 60), eliminating the judder of rate resampling; "Match resolution" picks the smallest mode that covers the stream so SD/HD content goes out 1:1 and the TV does the upscaling. Everything is off by default and gated per source (live TV / recordings / mediaplayer) in the new "Display Mode" setup group.
• New: anamorphic SD modes (720x576/720x480 on 16:9) are fully compensated -- correct picture geometry, aligned OSD, and screenshots widened back to square pixels.
• New: `SVDRP PLUG vaapivideo MODE` lists the connector's usable modes with exact rates and shows the matcher's current decision.
• New: the mediaplayer keeps a persistent resume bookmark -- restarting the last-played file continues at the saved position, and the file browser reopens with the cursor on it.
• Fixed: TS files with raw-ADTS AAC (e.g. LG demo clips) now play with sound instead of falling back to video-only.
• Fixed: audio-only (radio) replays end properly at EOF instead of hanging on the last frame; audio-only replays now report a proper STC.
• Improved: trick play pacing -- slow/fast forward and reverse hold each frame for a content-correct interval, and PTS discontinuities no longer stall or race the stepping.
• Improved: mediaplayer subtitle handling hardened against malformed cues and markup.
• Improved: cleaner diagnostics -- no spurious `miss` counts during channel switches and mode changes, and tidier audio open log lines.
• Docs: README restructured and condensed; AVSYNC.md gains a table of contents and a constants reference that matches the source.

Hi,

ich habe ein spannendes Thema in vaapivideo eingebaut: dynamische Auflösungen, dynamische Bildfrequenzen. Es ist nun möglich, z.B. beim Live-TV dynamisch zwischen FHD und UHD nativ umzuschalten oder z.B. im Mediaplayer Files mit der richtigen Bildfrequenz abzuspielen. Man kann z.B. auch SD-Content nativ in PAL-Auflösung ausgeben, damit das TV skaliert.

Ich finde das Feature sehr hilfreich, insbesondere bei Mediendateien kann die Bildqualität erheblich verbessert werden. Bitte schaut Euch das Feature an, gebt mir Feedback. Ist die Menügestaltung verständlich? Ich bin gespannt auf konstruktive Verbesserungsvorschläge.

Quote from carel

Hi Zork, on your way to obsolete Kodi!

I saw below in my logs after I upgraded the plugin:

Code

Jul 30 13:53:15 user.err        tuinhuisje      vdr: [1217409] vaapivideo/config: invalid MaxRefreshRate value '-469156928'
Jul 30 13:53:15 user.err        tuinhuisje      vdr: [1217409] ERROR: unknown config parameter: vaapivideo.MaxRefreshRate = -469156928
Jul 30 13:53:15 user.err        tuinhuisje      vdr: [1217409] vaapivideo/config: invalid MinResolution value '22027'
Jul 30 13:53:15 user.err        tuinhuisje      vdr: [1217409] ERROR: unknown config parameter: vaapivideo.MinResolution = 22027

After a manual cleanup of the saved settings:

Minimum resolution:	1080p
Maximum refresh rate:	60 Hz

and a VDR restart I'm back with the strange values above

Thanks

There was a glitch in the parameter handling in vdr itself, I fixed it by implementing a self-healing function. Please switch to 1.8.1 and test again!

Release 1.8.1

Fixes for the new display-mode switching, and self-repairing settings

• Settings that got written unreadable no longer stick. VDR preserves and re-saves any setup.conf line a plugin rejects, so a corrupted value came back after every restart -- and editing setup.conf while VDR was running was silently undone when it shut down. The plugin now falls back to the default, rewrites the line, and logs what it replaced. Anyone seeing "unknown config parameter: vaapivideo.MaxRefreshRate" or a Display Mode setting that refuses to stick is fixed on the next start, no manual edit
• "Minimum resolution" and "Maximum refresh rate" survive a restart again
• Mode switching now works when --resolution names a pixel-repetition timing such as 1440x576. Those rasters are filtered out of the candidate list, which previously left the matcher with nothing to pick and disabled switching entirely for that output
• Slightly lower decode-thread overhead in the three seconds after a mode change, and no redundant re-evaluation when the mediaplayer opens a file with an NTSC frame rate. Malformed containers can no longer report a nonsense refresh rate to the matcher
• Log levels reviewed across the plugin: fewer errors that are not errors (a soft software-decode warning, subtitle packets that fail to decode), codec names instead of numeric ids, and consistent message prefixes -- so `-l 2` shows what actually needs attention

Quote from FireFly

Du kannst nicht mehr benötigte Parameter aus der setup.conf löschen, indem Du sie ohne Wert übergibst, z.B. SetupStore("MaxRefreshRate"); Siehe auch plugins.html

Ja, stimmt, baue ich ein.

Quote from carel

Hi Zork, thanks for the new update.

VDR coredumps when I want to save my settings in the OSD, I tried to save "switch for live TV" to "on"

I could narrow it down to the "multiple digits menu items" patch

My vaapivideo setup:

Code

vaapivideo.ClearOnChannelSwitch = 0
vaapivideo.DeinterlaceMode = 0
vaapivideo.DenoiseMode = 1
vaapivideo.HdrMode = 0
vaapivideo.MatchRefreshRate = 1
vaapivideo.MatchResolution = 1
vaapivideo.MaxRefreshRate = 1
vaapivideo.MinResolution = 1
vaapivideo.ModeSwitchLiveTv = 0
vaapivideo.ModeSwitchMediaplayer = 0
vaapivideo.ModeSwitchReplay = 0
vaapivideo.PassthroughLatency = 0
vaapivideo.PassthroughMode = 0
vaapivideo.PcmChannelMode = 0
vaapivideo.PcmLatency = 0
vaapivideo.ScaleMode = 0
vaapivideo.SharpenMode = 0
vaapivideo.Zoom1 = 344
vaapivideo.Zoom2 = 125
vaapivideo.Zoom3 = 0
vaapivideo.Zoom4 = 0
vaapivideo.Zoom5 = 0

Display More

Coredump and the patch I used attached.. just in case you want to have a look

For now I removed the patch

Carel

Display More

Understand, I think your setup is broken:

MULTIPLE_DIGITS_MENU_ITEMS.patch inserts two members into cOsdMenu's private section:

   bool hasHotkeys;
+  int key_nr;
+  cTimeMs lastActivity;
   bool active;

so sizeof(cOsdMenu) grows. So: The plugin must be compiled against the headers matching the running vdr binary. Your vdr is the patched 2.8.2-1 tree; your libvdr-vaapivideo.so was built against unpatched headers. Either rebuild the plugin against /home/carel/src/vdr/vdr-2.8.2-1/, or drop the patch.

Quote from pixelpeter

Hallo in die Runde,

Ich habe aktuell das Problem das ich auf hd+ Kanälen keinen Ton habe.

In der Aufnahme ist aber eine ac3 Spur vorganden. Scheinbar gibt es nur diese.

Da ich im Moment keinen ac3 fähigen Receiver habe sondern direkt mit hdmi in den Fernseher gehe scheint das das Problem zu sein. Kann ich an der Audioazsgabe einstellen das immer Stereo ausgegeben wird?

Peter

Wenn Dein AVR AC3 nicht anbietet, wird automatisch PCM ausgegeben. Das wird aus dem EDID ausgelesen.