[SkinNopacity] Aktuelle Probleme

ja, funktioniert nun.

Fürs Protokoll: Beim Kompilieren mit gcc-9.3.0 gibt es eine Warnung (war wohl auch vorher schon da):

usr/include/GraphicsMagick -o menudetailview.o menudetailview.c
menudetailview.c: In member function ‘void cNopacityMenuDetailViewLight::DrawPoster()’:
menudetailview.c:703:13: warning: ‘posterHeightOrig’ may be used uninitialized in this function [-Wmaybe-uninitialized]
703 |         int overlapHeight = posterHeightOrig - contentHeight;
|             ^~~~~~~~~~~~~
menudetailview.c:689:5: warning: ‘posterWidthOrig’ may be used uninitialized in this function [-Wmaybe-uninitialized]
689 |     if (posterWidthOrig == 0)
|     ^~

was ich immer schon mal fragen wollte...

Das syslog ist durchdrungen von Meldungen wie dieser:

Aug 14 10:59:19 ubuntuvdr2 vdr: [1190] nopacity: trying to load: /usr/local/share/vdr/plugins/skinnopacity/icons/darkblue/menuIcons/Schedule.png
Aug 14 10:59:19 ubuntuvdr2 vdr: [1190] nopacity: Magick Error: Magick: Unable to open file (/usr/local/share/vdr/plugins/skinnopacity/icons/darkblue/menuIcons/Schedule.png) reported by mag>
Aug 14 10:59:19 ubuntuvdr2 vdr: [1190] nopacity: trying to load: /usr/local/share/vdr/plugins/skinnopacity/icons/menuIcons/Schedule.png
Aug 14 10:59:19 ubuntuvdr2 vdr: [1190] nopacity: /usr/local/share/vdr/plugins/skinnopacity/icons/menuIcons/Schedule.png sucessfully loaded

In der gleichen Sekunden kann eine Grafik nicht geladen werden und dann geht es plötzlich doch. Das betrifft sämtliche menue icons und channel logos, sobald im OSD ein Menüpunkt ausgewählt wird. Beim einfachen Umschalten eines Senders gibt es aber keine Meldung wegen der Logos.

Das wird unglaublich viel geloggt, wenn ich nach einem Kanalwechsel das OSD öffne und den Punkt "Programm" öffne (siehe Anlage)

Danke, jetzt ist Ruhe

Zitat von lnj

I'll check vdpau.

lnj: this patch fixes the problem in #75. There is a bug in VdpauBlackSurface

diff -ur vdr-plugin-softhddevice-vdpau-vaapi-cuvid/video.c vdr-plugin-softhddevice-vdpau-vaapi-cuvid-vdpaublacksurface-fix/video.c
--- vdr-plugin-softhddevice-vdpau-vaapi-cuvid/video.c	2021-11-26 15:33:17.000000000 +0100
+++ vdr-plugin-softhddevice-vdpau-vaapi-cuvid-vdpaublacksurface-fix/video.c	2021-11-28 16:33:43.697723331 +0100
@@ -10402,10 +10402,8 @@
///
///	@param decoder	VDPAU hw decoder
///
-///	@FIXME: render only video area, not fullscreen!
-///	decoder->Output.. isn't correct setup for radio stations
///
-static void VdpauBlackSurface(VdpauDecoder * decoder)
+static void VdpauBlackSurface()
{
VdpStatus status;
VdpRect source_rect;
@@ -10415,19 +10413,10 @@
source_rect.y0 = 0;
source_rect.x1 = 0;
source_rect.y1 = 0;
-
-    // FIXME: what happens with PIP?
-    if (0) {
-	// FIXME: wrong for radio channels
-	output_rect.x0 = decoder->OutputX;	// video output (scale)
-	output_rect.y0 = decoder->OutputY;
-	output_rect.x1 = decoder->OutputX + decoder->OutputWidth;
-	output_rect.y1 = decoder->OutputY + decoder->OutputHeight;
-    } else {
-	output_rect.x0 = decoder->VideoX;
-	output_rect.y0 = decoder->VideoY;
-	output_rect.x1 = decoder->VideoWidth;
-	output_rect.y1 = decoder->VideoHeight;
+	output_rect.x0 = 0;
+	output_rect.y0 = 0;
+	output_rect.x1 = OsdWidth;
+	output_rect.y1 = OsdHeight;
}

// FIXME: double buffered osd disabled

Ok, I'll test it.

Dr. Seltsam Thank you for reminding me and suggesting the direction.

Fix in git now.

lnj :With your code (which is different from my solution - I used the whole 1920x1080 instead of the scaled size) there is still a small flickering on radio channels in a certain situation:

When "black picture during channel switch' is activated and no radio plugin running, the screen becomes black on radio channels. If I press ok, the channel name is displayed. So long all o.k. But if I press immidiately Menu (before the channel name disappears), there is a small flickering on the left side of the preview window.

It is possible that this is a bug in nopacity- maybe related to another bug (which seems to be in nopacity): If 'black picture during channel switch' is not set to 'on' in softhddevice config and we switch from a video channel to a radio channel, the screen keeps a freezed picture from the previous video channel. The channel name display does not disappear automatically. It is not possible to remove it with the back key. If you press menu, the menu appears, but it is not possible to close it. Strange things happen if you select another menu entry and closes this.

kamel5: Maybe you can check this? I don't have these problems with other Skins. I use skinnopacity 1.1.9-Test from devel branch with Dark Blue theme.

Läuft sonst gut bei mir.

Wie funktioniert denn die 6400? Gibt es da bei Playmode pmNone immer ein Schwarzbild? Dann wirst Du den Bug kaum nachvollziehen können. Ich vermute den Fehler aber bei nopacity, denn andere Skins (auch nopacity unter skindesigner) haben das Problem nicht.

Zitat von Dr. Seltsam

It is possible that this is a bug in nopacity- maybe related to another bug (which seems to be in nopacity): If 'black picture during channel switch' is not set to 'on' in softhddevice config and we switch from a video channel to a radio channel, the screen keeps a freezed picture from the previous video channel. The channel name display does not disappear automatically. It is not possible to remove it with the back key. If you press menu, the menu appears, but it is not possible to close it. Strange things happen if you select another menu entry and closes this.

You are right, this is a bug of vdpau video path, with cuvid all works fine. I'll take a look.

Hallo, ich habe gerade Deine neue Version getestet und mich gewundert, dass bei UHD Sendern das Icon für SD angezeigt wird:
In zwei Funktionen wurde bei UHD Breite mit Höhe vertauscht, hier der Fix dazu:

diff --git a/displaychannelview.c b/displaychannelview.c
index 885a970..6a8f54b 100644
--- a/displaychannelview.c
+++ b/displaychannelview.c
@@ -543,10 +543,11 @@ cString cNopacityDisplayChannelView::GetScreenResolutionIcon(void) {
     int screenHeight = 0;
     double aspect = 0;
     cDevice::PrimaryDevice()->GetVideoSize(screenWidth, screenHeight, aspect);
+    esyslog ("skinnopacity: %s %s %d %ix%i\n", __FILE__, __func__,  __LINE__, screenWidth, screenHeight);
     cString iconName("");
     switch (screenWidth) {
-        case 4320: // 7680 x 4320 = 8K UHD
-        case 2160: // 3840 x 2160 = 4K UHD
+        case 7680: // 7680 x 4320 = 8K UHD
+        case 3840: // 3840 x 2160 = 4K UHD
             iconName = "skinIcons/uhd4k";
             break;
         case 1920:
diff --git a/displayreplay.c b/displayreplay.c
index 1b91787..93c6b93 100644
--- a/displayreplay.c
+++ b/displayreplay.c
@@ -273,11 +273,11 @@ void cNopacityDisplayReplay::DrawScreenResolution(void) {
     int screenHeight = 0;
     double aspect = 0;
     cDevice::PrimaryDevice()->GetVideoSize(screenWidth, screenHeight, aspect);
-//    esyslog ("skinnopacity: %s %s %d %ix%i\n", __FILE__, __func__,  __LINE__, screenWidth, screenHeight);
+    esyslog ("skinnopacity: %s %s %d %ix%i\n", __FILE__, __func__,  __LINE__, screenWidth, screenHeight);
     cString iconName("");
     switch (screenWidth) {
-        case 4320: // 7680 x 4320 = 8K UHD
-        case 2160: // 3840 x 2160 = 4K UHD
+        case 7680: // 7680 x 4320 = 8K UHD
+        case 3840: // 3840 x 2160 = 4K UHD
             iconName = "skinIcons/uhd4k";
             break;
         case 1920:

Schöne Grüße

Lothar

Hallo,

bleibt noch DVB-T2 mit 1080p da wird noch 1080i angezeigt.

CU

9000h

kamel5 Danke für die Übernahme.

Eins ist mir noch aufgefallen: Während des Umschaltens liefert GetVideoSize() manchmal 0x0. Dann wird der Default sd576i gezogen. Ich fände es schöner, wenn in dem Fall kein oder ein "leeres" Icon angezeigt würde.

Schöne Grüße

Lothar