yavdr 0.6.2 vdr-plugin-channelscan?

There is still the same issue as discussed in the PMs - the plugin crashes with vdr 2.2.0 (at least with the patched version in yaVDR 0.6) when opening the plugin menu and I am still not shure how to fix this properly (and the build warnings show that the plugin isn't necessarily nicely written C++ code). If you can provide a working solution I am happy to include it, otherwise you will have to wait until someone else finds a way to fix this.

There already is the vdr-plugin-wirbelscan and the standalone tool w_scan (package w-scan) for channel scanning in the PPA.

>> vdr-plugin-wirbelscan; not doing a single tp scan.

The plugin itself supports it, but it would require you to supply any expert detail on the underlying physical transport.

And some GUI like second plugin that supports it or console work.

It makes sense only if you are an expert.

There is not a any question on this issue on the git.

Sorry, C ++ code is really not very good, I have no much time, but I try to keep plugin in working condition.

I have no problem with original vdr 2.2.0, and I have no desire and time to install yavdr.

If you tell me which plugins or patches a problem arises, I will try to solve it.

Zitat von lnj

If you tell me which plugins or patches a problem arises, I will try to solve it.

It seems it crashes only if the vdr-plugin-dynamite (which requires the following patch for vdr: https://github.com/flensrocker…s/vdr-2.2.0-dynamite.diff) has been loaded. If I disable the plugin (sudo vdrctl disable dynamite), the crash on opening the plugin menu disappears (in this case one must delay starting the vdr until all dvb devices are ready).

I had to apply the following changes in order build and package the plugin - ggc 4.8.4 doesn't seem to like variable length arrays (whose size isn't known at compile time), so I made it a vector and the Makefile failed to respect DESTDIR and the vdr.pc provided by the package vdr-dev:

--- a/filter.c
+++ b/filter.c
@@ -1279,7 +1279,7 @@
       SI::Loop::Iterator it2;
       SI::FrequencyListDescriptor *fld = (SI::FrequencyListDescriptor *)ts.transportStreamDescriptors.getNext(it2, SI::FrequencyListDescriptorTag);
       int NumFrequencies = fld ? fld->frequencies.getCount() + 1 : 1;
-      int Frequencies[NumFrequencies] = {0};
+      std::vector<int> Frequencies(NumFrequencies, 0);
       if (fld) {
          int ct = fld->getCodingType();
          if (ct > 0) {
@@ -1362,7 +1362,7 @@
                  int Frequency = Frequencies[0] = BCD2INT(sd->getFrequency()) / 10;
                  static int Modulations[] = { QPSK, QAM_16, QAM_32, QAM_64, QAM_128, QAM_256, QAM_AUTO };
 #if VDRVERSNUM < 20305
-                 int Modulation = Modulations[min(sd->getModulation(), 6)];
+                 int Modulation = Modulations[std::min(sd->getModulation(), 6)];
 #else
                  int Modulation = Modulations[std::min(sd->getModulation(), 6)];
 #endif
--- a/Makefile
+++ b/Makefile
@@ -22,11 +22,11 @@
 
 ### The directory environment:
 
-VDRDIR = ../../..
-LIBDIR = ../../lib
-PKGCFG = $(if $(VDRDIR),$(shell pkg-config --variable=$(1) $(VDRDIR)/vdr.pc),$(shell pkg-config --variable=$(1) vdr || pkg-config --variable=$(1) ../../../vdr.pc))
-LIBDIR = $(DESTDIR)$(call PKGCFG,libdir)
-LOCDIR = $(DESTDIR)$(call PKGCFG,locdir)
+#VDRDIR = ../../..
+#LIBDIR = ../../lib
+PKGCFG = $(if $(VDRDIR),$(shell pkg-config --variable=$(1) $(VDRDIR)/vdr.pc),$(shell PKG_CONFIG_PATH="$$PKG_CONFIG_PATH:../../.." pkg-config --variable=$(1) vdr))
+LIBDIR = $(call PKGCFG,libdir)
+LOCDIR = $(call PKGCFG,locdir)
 #
 
 TMPDIR ?= /tmp
@@ -114,7 +114,7 @@
 
 I18Npo    = $(wildcard $(PODIR)/*.po)
 I18Nmo    = $(addsuffix .mo, $(foreach file, $(I18Npo), $(basename $(file))))
-I18Nmsgs  = $(addprefix $(LOCDIR)/, $(addsuffix /LC_MESSAGES/vdr-$(PLUGIN).mo, $(notdir $(foreach file, $(I18Npo), $(basename $(file))))))
+I18Nmsgs  = $(addprefix $(DESTDIR)$(LOCDIR)/, $(addsuffix /LC_MESSAGES/vdr-$(PLUGIN).mo, $(notdir $(foreach file, $(I18Npo), $(basename $(file))))))
 I18Npot   = $(PODIR)/$(PLUGIN).pot
 
 %.mo: %.po
@@ -127,7 +127,7 @@
     msgmerge -U --no-wrap --no-location --backup=none -q -N $@ $<
     @touch $@
 
-$(I18Nmsgs): $(LOCDIR)/%/LC_MESSAGES/vdr-$(PLUGIN).mo: $(PODIR)/%.mo
+$(I18Nmsgs): $(DESTDIR)$(LOCDIR)/%/LC_MESSAGES/vdr-$(PLUGIN).mo: $(PODIR)/%.mo
     install -D -m644 $< $@
 
 ### Targets:
@@ -140,14 +140,15 @@
 .PHONY: i18n-dist
 i18n-dist: $(I18Nmsgs)
 
-all: libvdr-$(PLUGIN).so i18n
+all: $(SOFILE) i18n
 
 $(SOFILE): $(OBJS)
-    $(CXX) $(CXXFLAGS) -shared $(OBJS) $(LDFLAGS) $(LIBS) -o $@
+    $(CXX) $(CXXFLAGS) -shared $(OBJS) $(LIBS) $(LDFLAGS) -o $@
 #    $(CXX) $(CXXFLAGS) -lbz2 -lz -shared $(OBJS) -o $@
 
 install-lib: $(SOFILE)
-    install -D $^ $(LIBDIR)/$^.$(APIVERSION)
+    @echo IN $(DESTDIR)$(LIBDIR)/$^.$(APIVERSION)
+    $(Q)install -D $^ $(DESTDIR)$(LIBDIR)/$^.$(APIVERSION)
 
 install: install-lib install-i18n

Thanks seahawk1986, I will watch this.

I made a commit for dynamite plugin.

Try.

I will make the other fixes later, while using the seahawk1986's diff, if necessary.

This seems to prevent the crash (at least in a VM without any DVB adapters) - I just uploaded a package for the commit eb9c7ff (https://launchpad.net/~yavdr/+…shed&field.series_filter=) - cuku: could you please test if this works for you once the package has been published (green checkmark)?

I will look again.

I tested with vdr-2.2.0 + dynamite patch, works for me.

I have segfault only if plug-in dynamite is loaded not last.

But this is not channelscan trouble, it should be.

cuku, vdr restarted immediately after the start, or after select channelscan in menu?

cuku, are you using a satip plugin?

seahawk1986, can you uncomment line 408 and 434 in csmenu.c, where //syslog ....

And rebild package?

And cuku would give us a syslog after that.

I see no reason yet.

Zitat von lnj

seahawk1986, can you uncomment line 408 and 434 in csmenu.c, where //syslog ....

And rebild package?

Here you go: https://launchpad.net/~yavdr/+…ield.series_filter=trusty

cuku, install again please for test, when you can, and give syslog with segfault.