Skinenigmang-plugin

Rene · 5. September 2017

Hi,

Is there an updated version somewhere for the Skinenigmang-plugin so it would compile against VDR-2.3.x? I can't change the skin to something else, because the rest of my family would not accept it It would suck if i could not upgrade to the 2.3.x-version of VDR

seahawk1986 · 5. September 2017

The most recent git snapshot (https://projects.vdr-developer…kinenigmang-master.tar.gz) can be compiled with vdr 2.3.8 with a small patch:

Diff

--- a/enigma.c
+++ b/enigma.c
@@ -1380,7 +1380,7 @@
   }

   lineHeight = pFontList->Height();
-  nMarkerGap = min(MarkerGap, lineHeight / 2 - 1); //lineHeight - 2 * MarkerGap
+  nMarkerGap = std::min(MarkerGap, lineHeight / 2 - 1); //lineHeight - 2 * MarkerGap
   xItemLeft = xBodyLeft + (EnigmaConfig.showMarker ? lineHeight : ListHBorder);
   xItemRight = (fShowLogo || fShowInfo ? xBodyRight : xInfoRight) - ListHBorder - SmallGap - SmallGap - SmallGap;
   int numItems = MaxItems();
@@ -3808,7 +3808,7 @@
   }

   lineHeight = pFontListItem->Height();
-  nMarkerGap = min(MarkerGap, lineHeight / 2 - 1); //lineHeight - 2 * MarkerGap
+  nMarkerGap = std::min(MarkerGap, lineHeight / 2 - 1); //lineHeight - 2 * MarkerGap
   int LogoSize = IconHeight;
   LogoSize += (LogoSize % 2 ? 1 : 0);
   currentIndex = -1;

Alles anzeigen

Rene · 5. September 2017

Hi,

Thanks! Great to see that it's not a forgotten skin. I got though the following error when compiling it:

Code

enigma.c: In constructor 'cSkinEnigmaDisplayMenu::cSkinEnigmaDisplayMenu()':
enigma.c:1383:49: error: 'min' was not declared in this scope
enigma.c:1383:49: note: suggested alternative:
/usr/include/c++/4.6/bits/stl_algobase.h:233:5: note:   'std::min'
enigma.c: In constructor 'cSkinEnigmaDisplayTracks::cSkinEnigmaDisplayTracks(const char*, int, const char* const*)':
enigma.c:3811:49: error: 'min' was not declared in this scope
enigma.c:3811:49: note: suggested alternative:
/usr/include/c++/4.6/bits/stl_algobase.h:233:5: note:   'std::min'
enigma.c: At global scope:
enigma.c:182:1: warning: 'clrTitleShadow' defined but not used [-Wunused-variable]
enigma.c:204:1: warning: 'clrMessageInfoFg' defined but not used [-Wunused-variable]
enigma.c:205:1: warning: 'clrMessageInfoBg' defined but not used [-Wunused-variable]
enigma.c:206:1: warning: 'clrMessageWarningFg' defined but not used [-Wunused-variable]
enigma.c:207:1: warning: 'clrMessageWarningBg' defined but not used [-Wunused-variable]
enigma.c:208:1: warning: 'clrMessageErrorFg' defined but not used [-Wunused-variable]
enigma.c:209:1: warning: 'clrMessageErrorBg' defined but not used [-Wunused-variable]
make: *** [enigma.o] Error 1

Alles anzeigen

Rene · 5. September 2017

Thanks for the patch! I guess i missed it

seahawk1986 · 5. September 2017

I edited the post above to add a small patch that should fix your compile error.

Rene · 5. September 2017

Yep, i found that, and got it compiled Would it be possible to add this patch to the master repo?

seahawk1986 · 5. September 2017

This is something the developer of the plugin should do - you could add a request for it to the bugtracker: [https://projects.vdr-developer…s/plg-skinenigmang/issues]

Skinenigmang-plugin

Jetzt mitmachen!

Teilen

Tags

Benutzer online in diesem Thema