[Announce] VA-API/VPP Support for vdr-plugin-softhddevice

Zitat von rofafor

..and those horizontal bars exists only with softhddevice? Have you tried other vaapi mediaplayers with vpp enabled on your system? I still think this is due to a incompatible library version or buggy driver.

Not that easy: kodi and mpv use vaapi-vpp, but only for deinterlacing, not the other filters such as the color_balance filters.
Both (compiled) programs work perfect.

The only user of other vpp filters I could found was
github.com/gbeauchesne/gstreamer-vaapi
after compiling this, I saw the horizontal bars !
and only if setting any vaapipostproc filter.

So you are right, it must be somethng in my system.

Greetings Rene

I know, but i see many minor flaws.

And to find the bugs, its easier to use my code, with less side effects, which i already knew.

My code: va-api-glx HD without sound.

vdr[6438]: video: decoder buffer empty, duping frame (467/4919) 8 v-buf
vdr[6438]: video:  6:48:07.938+8888    0   0/\ms   8+1 v-buf

The v-buf never fills. The +1 should become +3 or even +4.

Same happens with va-api branch, but with random frames containing yellow or green bars.

Johns

Yes it runs very smooth. Bob, MADI, MCDI.

Only the bad frames are still there. Sometimes 15min without any failure, than 1min bad frames.
I noticed, that I had denoise and sharpen activated. Changing it while the channel is running:

video/vaapi: gpu hung 5971ms 3
ratio: 16:9 6080:3429
[h264 @ 0x7face1241c80] decode_slice_header error
1769ms 0ms 869ms
Segmentation fault


vdr[25157]: vaapi/vpp: Wrong number of forward references. Needed 0, got 1
vdr[25157]: Changing to 0 forward reference surfaces for postprocessing
kernel: softhddev video[25173]: segfault at 7fe970052000 ip 00007fe97253eff3 sp 00007fe974e08920 error 6 in i965_drv_video.so[7fe972500000+1aa000]


....

And changing the scaler to HQ, produces a green grid.

I think there is a bug, when no filter is used or needed 720p without denoise, sharpen, .... crash.

And the horizontal bars, can be a frame not ready. I have the fealing 576i with only deinterlacer has no bad frames anymore.

Johns

Its a general problem. The green horizontal bars happens with SDTV, HDTV, ... .
The bars can be also yellow, red, blue, ...

The crash only happens without any vpp filters and 720p.

Disabling the filters didn't improved it today. I have still many of the bad frames.
Yesterday they was less, but i let it running some hours before testing.

Johns

Mmm, today they are complete gone from SDTV.

720p crashs when i use anything others then 0 for Denoise or Sharpen.

vdr[31990]: video/vaapi: vaSyncSurface failed: invalid VASurfaceID
vdr[31990]: Surface 0 query status = 0x6: invalid VASurfaceID
vdr[31990]: vaapi/vpp: Wrong number of forward references. Needed 0, got 1
vdr[31990]: Changing to 0 forward reference surfaces for postprocessing
kernel: softhddev video[32006]: segfault at 7f6c680de000 ip 00007f6c6ee23083 sp 00007f6c7df9f930 error 6 in i965_drv_video.so[7f6c6ede4000+1ab000]
kernel: [drm] RC6 on
kernel: [drm] stuck on render ring
kernel: [drm] GPU HANG: ecode 9:0:0x85ddfffb, reason: Ring hung, action: reset
kernel: [drm:i915_set_reset_status] *ERROR* gpu hanging too fast, banning!
kernel: drm/i915: Resetting chip after gpu hang

Same with GIT version of libva and libva-intel-driver.

Now testing ffmpeg 2..7 and sharpen or denoise.

Same with ffmpeg 2.7.
Sharpen must be 0 otherwise crash.

Seems that 720p is producing the bad frames, when i never switch to 720p i get no bad frames on SDTV channels.

Johns

There is something wrong with the denoise parameters.
The config says 50 = default, the default should be off.
With 0 the denoise is disabled.

I have now all filters disabled (inserted "break;"), now everything seems to run fine, now longer testing.

Johns

Hi,

johns
sieht besser jetzt besser aus, ich hab auch keine grünen horizontale Linien mehr mit vaapi, vaapi-glx stürzt bei mir sofort ab.
Ich kann X11 auch live von 1080 auf 4K 2160p umschalten und vdr läuft weiter
SD pumpt irgendwie, 720p sieht ok aus, 1080i Servus Logo flackert noch etwas.

Intel(R) Celeron(R) CPU N3150

Linux satip 4.3.0-999-generic #201510012204 SMP Fri Oct 2 02:06:34 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

libva info: VA-API version 0.38.0
libva info: va_getDriverName() returns 0
libva info: Trying to open /usr/lib/x86_64-linux-gnu/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_0_38
libva info: va_openDriver() returns 0
lt-vainfo: VA-API version: 0.38 (libva 1.6.2.pre1)
lt-vainfo: Driver version: Intel i965 driver for Intel(R) CherryView - 1.6.2.pre1 (1.6.1-52-g589b7a8)

ffmpeg 2.8

http://projects.vdr-developer.…g-softhddevice/repository

CU
9000h

johns

As I see it, the denoise parameters are from the driver caps. I too got 720p crashes which are gone with following fix

--- softhddevice.orig/video.c   2015-10-04 14:52:35.676357063 +0200
+++ softhddevice/video.c        2015-10-06 12:09:51.572035914 +0200
@@ -3347,6 +3347,10 @@
         vaSyncSurface(VaDisplay, frefs[*num_frefs - 1]);


     /* Skip postprocessing if queue is not deinterlaceable */
+    if (!*num_brefs) {
+        //Error("vaapi/vpp: Postprocessing without Backward Reference\n");
+        return VA_STATUS_ERROR_INVALID_PARAMETER;
+    }
     for (i = 0; i < *num_brefs; ++i) {
         va_status = vaQuerySurfaceStatus(VaDisplay, brefs[i], &va_surf_status);
         if (va_status != VA_STATUS_SUCCESS) {

This situation comes up in interlaced material too, but crashes only with 720p. Maybe this can contribute to a solution

Cheers

Than fix the code!

You disable the denoise filter, when denoise is 0.
When 0 is not off, than don't disable the denoise filter, when the value is 0.
Use -1 for off, and 0 - N for the denoise filter and say 50 = default or write in the menu text "value in [] is default".
Or an extra option to disable the filter, but not how its now.

Johns

It is always a problem with cheap hardware. There was NVidia cards which can't handle all the stuff.
The VDPAU always use/setup the filter, if it was supported by the hardware.
I don't know if Intel GPUs with less EU, can handle all the filters.

I was adding some timeing debugs, to see where the time is spend.

I would add an extra option to disable the filters.

Johns

Denoise: 0 to 100, 50 is default. Is the 50 off? or 0?
Sharpen 0 to 100, 50 is default. 50 should be off? 0 is soften, 100 is sharpen.

Edit: Currently denoise of 0 and sharpen of 0 turns the filter off, but this is a bug.
What I wanted to know. is which value does the less denoise or is the default the neutral position?

Johns

I don't quite get the problem, I can setup 720p.Denoise to 0 in the setup e.g.
This means the denoise-filter is not applied. This has nothing to do with the default value.
For 720p with all filters set to 0 in setup (which is the default) filter_count remains 0 in VaapiApplyFilters(),
for interlaced resolutions at least the deinterlace-filter is called.

The problem, that leads to a crash in my system is VaapiPostprocessSurface is called even with a filter_count of 0.
If I apply following fix

--- softhddevice.orig/video.c	2015-10-04 14:52:35.676357063 +0200
+++ softhddevice/video.c	2015-10-11 20:32:09.675780276 +0200
@@ -3559,6 +3559,8 @@
         vaUnmapBuffer(VaDisplay, *decoder->vpp_deinterlace_buf);
     }
 
+    if (!filter_count)
+        return NULL; // no postprocessing if no filters applied
 
     va_status = VaapiPostprocessSurface(decoder->vpp_ctx, decoder->PlaybackSurface, *surface,
 		    filters_to_run, filter_count,

my system runs mostly stable without any artefacts. My previous fix is not needed anymore.