[softhddevice] [SOLVED] Plugin doesn't compile with vdr-2.1.3

arkoko · 6. Januar 2014

With the last developer VDR release plugin does not compile anymore:

Code

In file included from /usr/local/src/vdr-2.1.3/include/vdr/dvbdevice.h:15:0,
             	from /usr/local/src/vdr-2.1.3/include/vdr/menuitems.h:14,
             	from /usr/local/src/vdr-2.1.3/include/vdr/plugin.h:14,
             	from softhddevice.cpp:26:
/usr/local/src/vdr-2.1.3/include/vdr/device.h:702:16: error: ‘virtual void cDevice::TrickSpeed(int, bool)’ was hidden [-Werror=overloaded-virtual]
   virtual void TrickSpeed(int Speed, bool Forward);
            	^
softhddevice.cpp:2054:18: error:   by ‘virtual void cSoftHdDevice::TrickSpeed(int)’ [-Werror=overloaded-virtual]
 	virtual void TrickSpeed(int);
              	^
cc1plus: some warnings being treated as errors
make: *** [softhddevice.o] Error 1

Alles anzeigen

Is there a reason of error due of changed TrickSpeed function in vdr?

Code

root@akovdr:/usr/local/src/vdr-2.1.3# fgrep -i trickspeed /usr/local/src/vdr-2.1.2/*.h
/usr/local/src/vdr-2.1.2/device.h:  virtual void TrickSpeed(int Speed);
/usr/local/src/vdr-2.1.2/player.h:  void DeviceTrickSpeed(int Speed) { if (device) device->TrickSpeed(Speed); }


root@akovdr:/usr/local/src/vdr-2.1.3# fgrep -i trickspeed /usr/local/src/vdr-2.1.3/*.h
/usr/local/src/vdr-2.1.3/device.h:  virtual void TrickSpeed(int Speed, bool Forward);
/usr/local/src/vdr-2.1.3/player.h:  void DeviceTrickSpeed(int Speed, bool Forward) { if (device) device->TrickSpeed(Speed, Forward); }

Is it possible to fix it? Without this plugin I'm blind
Sorry, I don't speak Deutch, but this forum is the best for the VDR things

br,
arkoko

TheChief · 6. Januar 2014

Use this Patch: https://github.com/CReimer/vdr…evice-vdr2.1.3compat.diff

mini73 · 6. Januar 2014

Hi,

vdr 2.1.3 adds a new parameter to TrickSpeed, so it must be added to the plugin with a

Code

#if APIVERSNUM > 20102
...new code...
#else
...old code...
#endif

I think johns, the author of the plugin, will soon add support for vdr 2.1.3.
Just watch the git: http://projects.vdr-developer.…-plugin-softhddevice.git/

Lars.

mini73 · 6. Januar 2014

TheChief
That's only a "will compile" patch, but do not take advantage of the new parameter.
Maybe there's something more needed, don't know for now.

Lars.

arkoko · 6. Januar 2014

Danke schön, meine Freunde!

johns · 6. Januar 2014

Auf http://projects.vdr-developer.org/issues/1667 achten, wenn der Patch im GIT ist.

Danke an CReimer.

Johns

Copperhead · 6. Januar 2014

Bitte, bitte... War ja auch ein bisschen Eigennützung

johns · 7. Januar 2014

Der "forward" Parameter ist nur zur Information da, falls das Device etwas für die Richtung anders machen muß.
Ich erkenne die Richtung selber, aber dies ist mehr ein Hack um ffmpeg zu einen besseren Ergebnis zu überlisten.

Patch ist nun im GIT. Als nächstes der Umlaut Patch.

Johns

mini73 · 7. Januar 2014

Lars

[softhddevice] [SOLVED] Plugin doesn't compile with vdr-2.1.3

Jetzt mitmachen!

Teilen

Tags