[UPnP/DLNA] Tester gesucht für Release-Candidates des neuen UPnP-Plugins V.1.0.0

Well, yes it is intentional to escape the didl content because it is an XML document inside an XML document. It would be an invalid xml document, if you have a second header line (<xml version...>). Have you ever tried other UPnP or DLNA servers than this one?

You may switch it off by simply commenting out the following line:

ixml::XmlEscapeSpecialChars(browseRequest.result);

in contentDirectory.cpp:321

I try to find the bug with the trailing ~. I hope it is a minor bug.

I am currently adding your patches. Thank you very much.

Could you please try the latest revision. I added XmlEscapeSpecialChars to all fields which could contain special chars. All the other fields should not contain any of those chars because I don't think this is intentional to escape in multiple layers. Anyway, please try it.

Edit: sorry, forgot to push it to remote git. It should be available now.

Well, I guess that adding the unescaped result into the DIDL skeleton it will fail to parse the XML result due to the additional XML header line. However, I am not really sure.

Have you tried another UPnP Server like Mediatomb, which is working with you Sony Player?

I changed the code to get a more or less valid XML document without encapsulation of the inner document. However, this is invalid in respect of the specs which leads to empty browse results on almost all devices I have. So, this is not the solution.

This is what I get:

POST /services/cds_control HTTP/1.0
Host: 192.168.178.13
User-Agent: Twisted PageGetter
Content-Length: 438
SOAPACTION: "urn:schemas-upnp-org:service:ContentDirectory:1#Browse"
content-type: text/xml ;charset="utf-8"
connection: close


<?xml version="1.0" encoding="utf-8"?><s:Envelope xmlns:ns0="urn:schemas-upnp-org:service:ContentDirectory:1" s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/" xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"><s:Body><ns0:Browse><ObjectID>0</ObjectID><BrowseFlag>BrowseMetadata</BrowseFlag><Filter>*</Filter><StartingIndex>0</StartingIndex><RequestedCount>0</RequestedCount><SortCriteria /></ns0:Browse></s:Body></s:Envelope>HTTP/1.0 200 OK
CONTENT-LENGTH: 941
CONTENT-TYPE: text/xml; charset="utf-8"
DATE: Fri, 02 Nov 2012 09:48:04 GMT
EXT:
SERVER: Linux/3.2.0-31-generic, UPnP/1.0, Portable SDK for UPnP devices/1.6.6
X-User-Agent: redsonic


<s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/" s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><s:Body>
<u:BrowseResponse xmlns:u="urn:schemas-upnp-org:service:ContentDirectory:1">
<Result>
<DIDL-Lite xmlns="urn:schemas-upnp-org:metadata-1-0/DIDL-Lite/" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:upnp="urn:schemas-upnp-org:metadata-1-0/upnp/" xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/">
<container id="0" parentID="-1" restricted="1" childCount="2">
<dc:title>VDR UPnP/DLNA MS</dc:title>
<upnp:class>object.container</upnp:class>
<dc:creator>Denis Loh</dc:creator>
<dc:description>VDR UPnP-DLNA MS</dc:description>
<upnp:longDescription>UPnP/DLNA compliant Media Server functionality for VDR</upnp:longDescription>
</container>
</DIDL-Lite>
</Result>
<NumberReturned>1</NumberReturned>
<TotalMatches>1</TotalMatches>
<UpdateID>0</UpdateID>
</u:BrowseResponse>
</s:Body> </s:Envelope>

The patch to get this output:

diff --git a/media/mediaManager.cpp b/media/mediaManager.cpp
index de87aa6..c47eda5 100644
--- a/media/mediaManager.cpp
+++ b/media/mediaManager.cpp
@@ -382,7 +382,8 @@ int cMediaManager::CreateResponse(MediaRequest& request, const string& select, c
         ++request.numberReturned;
       }
 
-      request.result = ixmlDocumenttoString(DIDLDoc);
+      //request.result = ixmlDocumenttoString(DIDLDoc);
+      request.result = ixmlNodetoString((IXML_Node*)DIDLDoc);
 
       ixmlDocument_free(DIDLDoc);
       return UPNP_E_SUCCESS;
diff --git a/server/contentDirectory.cpp b/server/contentDirectory.cpp
index c014804..766a452 100644
--- a/server/contentDirectory.cpp
+++ b/server/contentDirectory.cpp
@@ -318,7 +318,7 @@ int cContentDirectory::Browse(Upnp_Action_Request* request){
     return request->ErrCode;
   }
 
-  ixml::XmlEscapeSpecialChars(browseRequest.result);
+  //ixml::XmlEscapeSpecialChars(browseRequest.result);
 
   std::stringstream ss;

You may try both, with encapsulation and without.

Does someone else have a Sony DLNA media player and may verify the behaviour of the plugin?

Zitat von rofafor

The packet looks better, but the device works worse Anyway, the <?xml?> header is now missing, so do you have any idea how to get it included, if the parser expects it? Btw. my Sony bluray player is the only one having these access problems, my Sony TV works nicely...

Told you You may "enable" the xml header by using ixmlDocumenttoString rather than ixmlNodetoString. However, this will create an invalid XML if you do not escape this document properly. You MUST escape the inner document, otherwise it is an invalid SOAP-DIDL document. If you player works then, it's crap

Zitat von rofafor

I ran an UPNP validator against the plugin and found out these ones:

I will check those. The device validator you're using runs on Windows only, doesn't it? I know this tool kit, it is based on the Intel Toolkit (btw. Intel is the main initiator of UPnP and one of the big members of DLNA. Sony and Samsung are the other ones. Microsoft is more or less a small part in this party). So, I don't think that Sony violates against their own specification.

Zitat von rofafor

VDR log:
UPnP Exception occurred while creating response for object '4bbe0364-a597-5981-bd12-6ecefacb804c': sqlite3_prepare: no such column: res@protocolInfo
UPnP Failed to process the request

Yet another bug, I guess. Thank you.

Zitat von rofafor

Test suite:
WARNING: Device not choosing Random interval based on MX value <<Standard Deviation: 0>>

Eh... what?

Zitat von rofafor

A few wishes:
- group separators of a channel list could be used as containers
- prefix channel names with channel numbers
- specify the verbosity of logging via a command line as in epgsearch

- okay. This is a known feature. I will implement it very soon.
- okay. I'd rather make the channel title customizable. For instance: %no% - %chan% - %title%. Then, you may add or remove more details. If there is currently no title, it will output only %no% - %chan%. It's because, wouldn't like to add too many information to the title because the space to display it is limited on most devices.
- okay, I will try it.

Hum... The problem is, that I try to delete old recordings from the table. I have to intersect the elements in the database and those, returned by the providers. If there are more than 1000 recordings, the expression fails with this exception.

I will try to fix that. However, it doesn't refer to the Browse request. The exception is caused by the scanner.

I added the channel group support, you'd like to have. Could you please test it and tell me if there are any bugs? I have only limited testing capabilities at the moment.

I will try to fix the other bugs.

edit: Fixed the res@protocolInfo bug.
edit 2: Fixed the 1000 entries bug. I hope it works for you, it does for me at least.

Ehm... sorry, as I told you, it shall be configurable. So, I will implement this tomorrow. Have you solved you Sony BD-Player issue?

I added an initial support for configuring the channel title. You just have to copy the channelTitle.conf into the configuration directory of the plugin. The configuration is self-explaining.

Again, it's not fnished yet, because it lacks a check if any of those variables is empty the delimiter is omitted from the output. I have no idea yet, which kind of pattern could be useful for that. Maybe, someone has a good idea for that!

Okay, I'll revert the special chars commit. However, I'll keep the config file. First, I was thinking the same thought as you - to pass setup lines to the plugins, then I saw that in that case I have to change the plugin api. The sub-plugins are more or less self-responsible about their configuration. Maybe this may change in future. The config file is optional and works without. I don't need the channel numbers.

I changed the parser, that now delimiters can be added to the variable. If the variable is not empty, the delimiter is prepended to the variable. See README of the Plugin and the example file.

Thank you again for this bugfix.

Ach mist. Sorry, die hab ich vorhin vergessen. Kannst du jetzt nochmal probieren?

edit: Reverted xmlSpecialChars for title, creator, description and longDescription. rofafor, could you please try latest revision?